This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix lit.cfg.py to set SYCL_DEVICE_FILTER correctly. #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use {SYCL_PLUGIN}: prefix for HOST/CPU/ACC_RUN_PLACEHOLDERs.
These are incorrect combination of BE:DEV_TYPE, and it will cause
device_selectors to return no device because they cannot find any device
that can satisfy that invalid combination.
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
bso-intel
commented
Mar 24, 2021
| found_at_least_one_device = True | ||
| lit_config.note("Tests accelerator device") | ||
| acc_run_substitute = " env SYCL_DEVICE_FILTER={SYCL_PLUGIN}:acc ".format(SYCL_PLUGIN=config.sycl_be) | ||
| acc_run_substitute = " env SYCL_DEVICE_FILTER=acc " |
Author
There was a problem hiding this comment.
It seems HOST should not be added for the ACC_RUN_PLACEHOLDER because currently HOST is higher heuristic point than ACC.
So, if we add host, the device_selectors will choose HOST instead of ACC.
vladimirlaz
approved these changes
Mar 24, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…m-test-suite#190) We should not use {SYCL_PLUGIN}: prefix for HOST/CPU/ACC_RUN_PLACEHOLDERs. These are incorrect combination of BE:DEV_TYPE, and it will cause device_selectors to return no device because they cannot find any device that can satisfy that invalid combination. Signed-off-by: Byoungro So <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not use {SYCL_PLUGIN}: prefix for HOST/CPU/ACC_RUN_PLACEHOLDERs.
These are incorrect combination of BE:DEV_TYPE, and it will cause
device_selectors to return no device because they cannot find any device
that can satisfy that invalid combination.
Also, added host for CPU/GPU_RUN_PLACEHOLDERs because the new implementation of SYCL_DEVICE_FILTER will not add the host device automatically. intel/llvm#3397
Signed-off-by: Byoungro So [email protected]