This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Replace std::fill in single_task with a fill command #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some targets may not support std::fill in kernel code. This commit changes a number of std::fill in kernel code to be a fill command on queue. Signed-off-by: Larsen, Steffen <[email protected]>
|
Hi @steffenlarsen , I tried this PR using latest sycl rev. There are a number of errors related to |
Author
|
@mmoadeli - I don't believe those issues are related to these changes. This was needed by CUDA testing on Windows as std::fill was causing problems. |
Author
|
@cperkinsintel - Friendly ping. |
cperkinsintel
approved these changes
Jan 31, 2023
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Some targets may not support std::fill in kernel code. This commit changes a number of std::fill in kernel code to be a fill command on queue. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…vm-test-suite#1049) Some targets may not support std::fill in kernel code. This commit changes a number of std::fill in kernel code to be a fill command on queue. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some targets may not support std::fill in kernel code. This commit changes a number of std::fill in kernel code to be a fill command on queue.