-
Notifications
You must be signed in to change notification settings - Fork 36
Fix pip install path issue for certain packages #90
Conversation
|
@carsonwang @KepingYan , please help to take a review. |
|
From https://docs.python.org/3/library/sys.html#sys.path python script.py command line: prepend the script’s directory. If it’s a symbolic link, resolve symbolic links. We should test and make sure it works in the following both cases and should allow the script to be run from any path:
|
Yeah, after all, the readme should provide User a smooth experience to Run a 'hello world' demo. |
|
We also need to consider the distributed nature of Ray that all workers should find the package. (may be the cause of this issue) Following the industrial practices, I would suggest move inference/finetune into a package For users, they can launch serve as @xuechendi We will discuss locally and let you know. |
|
@xuechendi We decided to use package path (move inference/finetune/... into a package llm_on_ray namespace) for import to avoid name conflict such as And use module when running Also need to install @KepingYan could you fix this in #79 as discussed? |
|
@xwu99 , That sounds great! This is also something I felt quite unusual that after installing llm-on-ray, the package name is not "llm-on-ray" but "inference". Great to know that you are going to fix the package name. :) Please feel free to close this PR once you have merge the other one. I would be willing to test the new installation by then. |
Signed-off-by: Xue, Chendi <[email protected]>
Signed-off-by: Xue, Chendi <[email protected]>
cef8a73 to
e47113b
Compare
|
fixed by #106 |
Fix relative path import.
Error Log before fixing:

After adding complete path, I am able to run serving.
1. install steps
2. test step: