This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Support latest Ray 2.10 release #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu-intel
changed the title
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
Signed-off-by: Wu, Xiaochang <[email protected]>
xwu-intel
changed the title
carsonwang
reviewed
Apr 1, 2024
Contributor
carsonwang
left a comment
carsonwang
left a comment
There was a problem hiding this comment.
Looks good. can you please merge master?
| serve.start(http_options={"host": infer_conf.host, "port": infer_conf.port}) | ||
| serve.run( | ||
| deployment, | ||
| _blocking=True, |
Contributor
There was a problem hiding this comment.
can we pass keep_serve_terminal and set it to the new blocking parameter in serve.run? Better to also rename keep_serve_terminal to blocking in our script which will be more consistent and easy to understand.
Author
There was a problem hiding this comment.
Let's keep current logic for this PR. We printed something after this call.
Use a separate PR to address the parameter, In the new version, user should use Ctrl-C to stop the program after this blocking call.
Author
Do we decide to update to Ray 2.10? it's a breaking change that lower versions will not work. |
Contributor
Yes, let's upgrade. Can you help create a branch in case if someone want to use Ray 2.9 or earlier versions, they can use that branch? |
Author
Created: https://github.com/intel/llm-on-ray/tree/llm-on-ray_for_ray_2.9 |
Signed-off-by: Wu, Xiaochang <[email protected]>
carsonwang
approved these changes
Apr 9, 2024
Contributor
|
Merged this. thanks! |
minmingzhu
pushed a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
Apr 11, 2024
* update * fix blocking * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * fix setup and getting started Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * nit Signed-off-by: Wu, Xiaochang <[email protected]> * Add dependencies for tests and update pyproject.toml Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and test workflow Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and fix torch_dist.py Signed-off-by: Wu, Xiaochang <[email protected]> * Update OpenAI SDK installation and start ray cluster Signed-off-by: Wu, Xiaochang <[email protected]> --------- Signed-off-by: Wu, Xiaochang <[email protected]>
minmingzhu
pushed a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
Apr 22, 2024
* update * fix blocking * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * fix setup and getting started Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * nit Signed-off-by: Wu, Xiaochang <[email protected]> * Add dependencies for tests and update pyproject.toml Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and test workflow Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and fix torch_dist.py Signed-off-by: Wu, Xiaochang <[email protected]> * Update OpenAI SDK installation and start ray cluster Signed-off-by: Wu, Xiaochang <[email protected]> --------- Signed-off-by: Wu, Xiaochang <[email protected]>
minmingzhu
pushed a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 6, 2024
* update * fix blocking * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * fix setup and getting started Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * nit Signed-off-by: Wu, Xiaochang <[email protected]> * Add dependencies for tests and update pyproject.toml Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and test workflow Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and fix torch_dist.py Signed-off-by: Wu, Xiaochang <[email protected]> * Update OpenAI SDK installation and start ray cluster Signed-off-by: Wu, Xiaochang <[email protected]> --------- Signed-off-by: Wu, Xiaochang <[email protected]>
minmingzhu
pushed a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 9, 2024
* update * fix blocking * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * fix setup and getting started Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * nit Signed-off-by: Wu, Xiaochang <[email protected]> * Add dependencies for tests and update pyproject.toml Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and test workflow Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and fix torch_dist.py Signed-off-by: Wu, Xiaochang <[email protected]> * Update OpenAI SDK installation and start ray cluster Signed-off-by: Wu, Xiaochang <[email protected]> --------- Signed-off-by: Wu, Xiaochang <[email protected]>
minmingzhu
pushed a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 16, 2024
* update * fix blocking * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * fix setup and getting started Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * update Signed-off-by: Wu, Xiaochang <[email protected]> * nit Signed-off-by: Wu, Xiaochang <[email protected]> * Add dependencies for tests and update pyproject.toml Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and test workflow Signed-off-by: Wu, Xiaochang <[email protected]> * Update dependencies and fix torch_dist.py Signed-off-by: Wu, Xiaochang <[email protected]> * Update OpenAI SDK installation and start ray cluster Signed-off-by: Wu, Xiaochang <[email protected]> --------- Signed-off-by: Wu, Xiaochang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.