Skip to content
This repository was archived by the owner on Sep 23, 2025. It is now read-only.

Conversation

@KepingYan
Copy link
Contributor

@KepingYan KepingYan commented Feb 5, 2024

closes #72
related to #79

@KepingYan KepingYan requested a review from harborn February 5, 2024 04:56
gpt_base_model: true
output_dir: /tmp/llm-ray/output
checkpoint_dir: /tmp/llm-ray/checkpoint
logger_name: tensorboard # only support tensorboard as tracker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name as log_with or tracking_with ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I asked in #99, do we need to log using both accelerate and Ray? It seems we logs the metrics twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synced with @harborn, we'll only keep ray report to log the metrics. It'll be modified in #103 , I've removed related codes in this pr.

@KepingYan KepingYan requested a review from carsonwang February 6, 2024 07:46
Copy link
Contributor

@carsonwang carsonwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KepingYan KepingYan merged commit 8baef62 into intel:main Feb 6, 2024
cheehook pushed a commit to JoshuaL3000/llm-on-ray that referenced this pull request Mar 8, 2024
* update docker file to fix SDLe CT222

* update Dockerfile

Signed-off-by: minmingzhu <[email protected]>

* update Dockerfile

Signed-off-by: minmingzhu <[email protected]>

* Update Dockerfile

* Update Dockerfile

* testing

Signed-off-by: minmingzhu <[email protected]>

* testing

Signed-off-by: minmingzhu <[email protected]>

* testing

Signed-off-by: minmingzhu <[email protected]>

* testing

Signed-off-by: minmingzhu <[email protected]>

* testing

Signed-off-by: minmingzhu <[email protected]>

* testing

Signed-off-by: minmingzhu <[email protected]>

* remove no-cache-dir

Signed-off-by: minmingzhu <[email protected]>

* Empty commit message

* remove no-cache-dir

Signed-off-by: minmingzhu <[email protected]>

---------

Signed-off-by: minmingzhu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] gradio package conflict

3 participants