This repository was archived by the owner on Sep 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
[UI] Add ui install script & fix ui #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harborn
reviewed
Feb 5, 2024
finetune/finetune.yaml
Outdated
| gpt_base_model: true | ||
| output_dir: /tmp/llm-ray/output | ||
| checkpoint_dir: /tmp/llm-ray/checkpoint | ||
| logger_name: tensorboard # only support tensorboard as tracker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name as log_with or tracking_with ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I asked in #99, do we need to log using both accelerate and Ray? It seems we logs the metrics twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carsonwang
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cheehook
pushed a commit
to JoshuaL3000/llm-on-ray
that referenced
this pull request
Mar 8, 2024
* update docker file to fix SDLe CT222 * update Dockerfile Signed-off-by: minmingzhu <[email protected]> * update Dockerfile Signed-off-by: minmingzhu <[email protected]> * Update Dockerfile * Update Dockerfile * testing Signed-off-by: minmingzhu <[email protected]> * testing Signed-off-by: minmingzhu <[email protected]> * testing Signed-off-by: minmingzhu <[email protected]> * testing Signed-off-by: minmingzhu <[email protected]> * testing Signed-off-by: minmingzhu <[email protected]> * testing Signed-off-by: minmingzhu <[email protected]> * remove no-cache-dir Signed-off-by: minmingzhu <[email protected]> * Empty commit message * remove no-cache-dir Signed-off-by: minmingzhu <[email protected]> --------- Signed-off-by: minmingzhu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #72
related to #79