-
Notifications
You must be signed in to change notification settings - Fork 306
ci: auto deploy the GitHub pages/docs on releases #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@evelikov : thank you for working on this change. Really appreciate. To which degree you have tested the PR? I wonder, did you try real deployment in your fork copy? If yes - can you post a link? |
It was quite a hit and miss, until I got it right to be honest. Ultimately I removed everything, since my fork became a complete mess. Please try the instructions in your fork and let me know if you hit any issues. |
Here is an illustrative example:
|
The FreeBSD failure seems unrelated. |
@dvrogozh is the above example and execution outline helpful? Is there anything I can do to move this forward? |
@XinfengZhang @dvrogozh humble ping? |
@dvrogozh @XinfengZhang is there anything more I can do here? |
LGTM, but have questions:
|
Their comment does not say what the problem is, so I have no idea. It just works in my testing.
I think you meant to say The action will trigger only when a new release is made - either via the web UI aka https://github.com/intel/libva/releases/new or the CLI tools. |
I am expecting "the actions only take effect with new tag generated" (first option in this sentence) , sorry for confusing. |
@XinfengZhang the English in the above sentence is a bit broken, so I am not sure what you mean. Are you aiming to correct your previous statement? Are you asking for the PR to be reworked? Something else? |
no, you already answered my question:
it is my expectation. thanks |
9c70e5a
to
87d3bd6
Compare
Glad to hear. Anything else I can do to have this merged? |
@XinfengZhang @dvrogozh humble poke - anything I can do to move this forward? |
Signed-off-by: Emil Velikov <[email protected]>
This workflow picks the latest version tag (via sort -V -r) and deploys it. Signed-off-by: Emil Velikov <[email protected]>
We use some unorthodox handling of the version - we suffix a "pre1" or a fourth digit in the meson case to indicate that. The top-level meson.build already swaps the digit - saving that as liva_version variable. Use the variable, otherwise the docs will list the wrong version. Signed-off-by: Emil Velikov <[email protected]>
87d3bd6
to
b623ec6
Compare
This adds a workflow, that triggers on GitHub releases, building/deploying the docs only when needed.
For example:
Notes:
gh-pages
branch can be removed ... we should also removeva_win
andrevert-583-HierarchyInfo
This MR builds upon and supersedes #642. Notable changes: