Skip to content

Align API version and package version #80

@dvrogozh

Description

@dvrogozh

I've built latest code and got library named "libiga64.so.1.0.0", but igc-opencl.pc has this line:
Version: 0.1.0

So, we have 2 versions now. Here is API version:

set(IGC_API_MAJOR_VERSION 1)

and here is another version:

set(MAJOR_VERSION 0)

The latter one is used in igc-opencl.pc.in:

Version: @MAJOR_VERSION@.@MINOR_VERSION@.@PATCH_VERSION@

I suggest to either completely remove "another" version or at least default it to API version like:

if(NOT DEFINED MAJOR_VERSION)
  set(MAJOR_VERSION ${IGC_API_MAJOR_VERSION})
endif()
if(NOT DEFINED MINOR_VERSION)
  set(MINOR_VERSION ${IGC_API_MINOR_VERSION})
endif()
if(NOT DEFINED PATCH_VERSION)
  set(PATCH_VERSION ${IGC_API_PATCH_VERSION})
endif()

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions