acl_hash: fix signedness conversion warnings for internal tail buffer #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signedness of `char` is platform-dependent, e.g., signed on the
platforms supported by the runtime, which causes the following integer
conversion warnings. `char` is appropriate for a buffer of characters,
whereas `unsigned char` is appropriate for a buffer of arbitrary bytes.
The signedness change only affects the internal implementation, i.e. the
internal tail buffer and the internal functions using that buffer. The
unit tests provide sufficient coverage to ensure correctness.
[2/14] Building C object lib/acl_hash/CMakeFiles/acl_hash.dir/src/acl_hash.c.o
../lib/acl_hash/src/acl_hash.c: In function ‘l_close’:
../lib/acl_hash/src/acl_hash.c:189:14: warning: conversion to ‘char’ alters ‘int’ constant value [-Wconversion]
extra[0] = 0x80; // append '1' bit. Assume big endian even within byte.
^~~~
../lib/acl_hash/src/acl_hash.c:199:20: warning: conversion to ‘char’ from ‘uint64_t {aka long unsigned int}’ may alter its value [-Wconversion]
extra[7 - i] = user_bits & 0xff;
^~~~~~~~~
zibaiwan
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signedness of
charis platform-dependent, e.g., signed on theplatforms supported by the runtime, which causes the following integer
conversion warnings.
charis appropriate for a buffer of characters,whereas
unsigned charis appropriate for a buffer of arbitrary bytes.The signedness change only affects the internal implementation, i.e. the
internal tail buffer and the internal functions using that buffer. The
unit tests provide sufficient coverage to ensure correctness.
Prerequisite of #85