Skip to content

Fix CSR Pipe #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix CSR Pipe #289

merged 1 commit into from
Apr 26, 2023

Conversation

zibaiwan
Copy link
Contributor

The previous return code checking was wrong. Also skip some register writing in the non-blocking case.

@zibaiwan zibaiwan requested a review from sophimao April 26, 2023 13:57
@zibaiwan zibaiwan added this to the 2023.2 milestone Apr 26, 2023
sophimao
sophimao reviewed Apr 26, 2023
View reviewed changes
sophimao
sophimao reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai! The change looks good overall, just one small nitpick as in the previous comment.

@zibaiwan zibaiwan requested a review from sophimao April 26, 2023 14:54
@zibaiwan zibaiwan merged commit f988ae0 into intel:main Apr 26, 2023
@zibaiwan zibaiwan deleted the csr-pipe-fix branch April 26, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophimao sophimao sophimao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
2 participants
@zibaiwan @sophimao