Fix token creation and stats #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnedj
approved these changes
Apr 27, 2023
byrnedj
left a comment
byrnedj
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @igchor)
vinser52
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented
byrnedj
pushed a commit
that referenced
this pull request
Jul 23, 2023
* Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented
vinser52
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented
vinser52
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented
byrnedj
added a commit
that referenced
this pull request
May 21, 2024
Part 2. ---------------------------- This patch introduces tryEvictToNextMemoryTier and some additional multi-tier tests. We can consider merging tryEvictToNextMemoryTier with the initial implementation and seperating the tests into a seperate patch. Per tier pool stats (multi-tier patch part 3.) -------------------- This introduces per tier stats this can go with multi-tier patch part 2. Fix token creation and stats (#79) (multi-tier patch 4.) --------------------------------- This patch can go after we implement tryEvictToNextMemoryTier (or multi-tier part 2) and should be combined as such. * Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented correct handling for expired items in eviction (#86) (multi-tier patch 5.) ----------------------------------------------------- This can be merged with patches that fix token creation and probably squashed into multi-tier patch 2. - we first check if an item is expired under mmContainer lock and if so mark it for eviction so it is recycled back up to allocateInternalTier.
byrnedj
added a commit
that referenced
this pull request
Jun 25, 2024
Part 2. ---------------------------- This patch introduces tryEvictToNextMemoryTier and some additional multi-tier tests. We can consider merging tryEvictToNextMemoryTier with the initial implementation and seperating the tests into a seperate patch. Per tier pool stats (multi-tier patch part 3.) -------------------- This introduces per tier stats this can go with multi-tier patch part 2. Fix token creation and stats (#79) (multi-tier patch 4.) --------------------------------- This patch can go after we implement tryEvictToNextMemoryTier (or multi-tier part 2) and should be combined as such. * Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented correct handling for expired items in eviction (#86) (multi-tier patch 5.) ----------------------------------------------------- This can be merged with patches that fix token creation and probably squashed into multi-tier patch 2. - we first check if an item is expired under mmContainer lock and if so mark it for eviction so it is recycled back up to allocateInternalTier.
byrnedj
added a commit
that referenced
this pull request
Jun 26, 2024
Part 2. ---------------------------- This patch introduces tryEvictToNextMemoryTier and some additional multi-tier tests. We can consider merging tryEvictToNextMemoryTier with the initial implementation and seperating the tests into a seperate patch. Per tier pool stats (multi-tier patch part 3.) -------------------- This introduces per tier stats this can go with multi-tier patch part 2. Fix token creation and stats (#79) (multi-tier patch 4.) --------------------------------- This patch can go after we implement tryEvictToNextMemoryTier (or multi-tier part 2) and should be combined as such. * Fix issue with token creation * Do not increment evictFail* stats if evictFailConcurrentFill were incremented correct handling for expired items in eviction (#86) (multi-tier patch 5.) ----------------------------------------------------- This can be merged with patches that fix token creation and probably squashed into multi-tier patch 2. - we first check if an item is expired under mmContainer lock and if so mark it for eviction so it is recycled back up to allocateInternalTier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously token was not destroyed in case we failed to mark the item as moving/for eviction.
As a result, in the next iteration, we could have ended up with a new item marked as moving but with a token associated with the previous item.
This change is