Initial support of NUMA bindings #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
numa_binding
branch
from
9a73b21 to
4b64e82
Compare
byrnedj
reviewed
Sep 3, 2022
byrnedj
left a comment
byrnedj
left a comment
There was a problem hiding this comment.
everything else looks good - I can compile and pass the tests.
cachelib/cachebench/CMakeLists.txt
Outdated
| add_test (consistency/tests/ValueHistoryTest.cpp) | ||
| add_test (consistency/tests/ValueTrackerTest.cpp) | ||
| add_test (util/tests/NandWritesTest.cpp) | ||
| add_test (util/tests/MemoryTierConfigTest) |
vinser52
force-pushed
the
numa_binding
branch
from
4b64e82 to
b0e2574
Compare
vinser52
commented
Sep 12, 2022
Author
vinser52
left a comment
vinser52
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion (waiting on @byrnedj and @igchor)
cachelib/cachebench/CMakeLists.txt line 92 at r1 (raw file):
Previously, byrnedj (Daniel Byrne) wrote…
should be MemoryTierConfigTest.cpp
Done
vinser52
force-pushed
the
numa_binding
branch
3 times, most recently
from
aeffcd8 to
b0e2574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is