typed-protocols: support QuickCheck 2.15 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds backward compatibility support for QuickCheck versions 2.15 and earlier by providing a compatibility shim for monoid types that were introduced in QuickCheck 2.16.
- Relaxes QuickCheck version constraint from >= 2.16 to allow earlier versions
- Adds compatibility module that provides missing monoid types for QuickCheck < 2.16
- Updates version to 1.1.0.1 with changelog entry
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| typed-protocols.cabal | Updates version, relaxes QuickCheck constraint, adds new compatibility module |
| Test/QuickCheck/Monoids/Compat.hs | New compatibility module providing All/Any/Every/Some types for QuickCheck < 2.16 |
| Network/TypedProtocol/Stateful/Codec/Properties.hs | Adds conditional import of compatibility module |
| Network/TypedProtocol/Codec/Properties.hs | Adds conditional import of compatibility module |
| CHANGELOG.md | Documents the new compatibility support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
coot
force-pushed
the
coot/quickcheck-2.15
branch
from
decbd40 to
3583af5
Compare
coot
force-pushed
the
coot/quickcheck-2.15
branch
from
3583af5 to
00bfc5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.