Scala3 support #108
Closed
Scala3 support #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
reviewed
Feb 13, 2024
shared/src/main/scala/scorex/crypto/authds/avltree/batch/PersistentBatchAVLProver.scala
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
stenolog
reviewed
Feb 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
CI fix
stenolog
reviewed
Feb 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
No thanks, @aslesarenko is all needed |
3 tasks
stenolog
reviewed
Feb 21, 2024
Contributor
@ccellado, I suggest to leave this PR open for a while and try to migrate Sigma using published snapshots. |
Contributor
Author
Agreed, that's the simple & safe way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt
Best one yet, separate source files for
authdsandhashfor scala 3 and 2Only five tests failling, runtime
TagcheckNeed to decide is that critical, could be omitted for scala3 version