Skip to content

Conversation

@SupernaviX
Copy link
Contributor

@SupernaviX SupernaviX commented Nov 12, 2025

Content

My PR #2776 used invalid shell syntax which broke the installer script. I didn't notice because I was using it as part of a larger script, and that script kept working because I had mithril-client installed globally. My bad 😅

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@SupernaviX SupernaviX marked this pull request as ready for review November 12, 2025 20:23
@jpraynaud jpraynaud merged commit 161e0fc into input-output-hk:main Nov 13, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants