refactor(signer): split signer aggregator client into several small business services

[Alenar]

Content

This PR includes a refactor to the mithril-signer inner architecture splitting its AggregatorClient into several small business service or removing unused method.

Details

• Implement SignaturePublisher directly on mithril_aggregator_client::AggregatorHttpClient, this allow for the removal of register_signature from the signer AggregatorClient
• Remove AggregatorClient::retrieve_aggregator_features which is no longer used since the introduction of the MithrilNetworkConfigurationProvider
• Add a new services::signer_registration module, with two submodules based on the architecture of the services::signature_publisher module:
  • publisher which extract the AggregatorClient::register_signer into a new SignerRegistrationPublisher trait
  • retriever which extract the AggregatorClient::retrieve_aggregator_features into a new SignersRegistrationRetriever
  • both new traits are implemented directly over the mithril_aggregator_client::AggregatorHttpClient
• streamline naming (rename certificate_handler to appropriate types)

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • No new TODOs introduced

Issue(s)

Closes #2759

[github-actions]

Test Results

    4 files  ±0    168 suites  ±0   24m 6s ⏱️ +36s
2 204 tests  - 3  2 204 ✅  - 3  0 💤 ±0  0 ❌ ±0 
6 881 runs   - 6  6 881 ✅  - 6  0 💤 ±0  0 ❌ ±0 

Results for commit 951dd5a. ± Comparison against base commit 161e0fc.

This pull request removes 9 and adds 6 tests. Note that renamed tests count towards both.

mithril-signer::create_cardano_transaction_single_signature ‑ test_extensions::certificate_handler::tests::register_signer
mithril-signer::create_cardano_transaction_single_signature ‑ test_extensions::certificate_handler::tests::retrieve_aggregator_features
mithril-signer::create_cardano_transaction_single_signature ‑ test_extensions::certificate_handler::tests::retrieve_epoch_settings
mithril-signer::create_immutable_files_full_single_signature ‑ test_extensions::certificate_handler::tests::register_signer
mithril-signer::create_immutable_files_full_single_signature ‑ test_extensions::certificate_handler::tests::retrieve_aggregator_features
mithril-signer::create_immutable_files_full_single_signature ‑ test_extensions::certificate_handler::tests::retrieve_epoch_settings
mithril-signer::era_switch ‑ test_extensions::certificate_handler::tests::register_signer
mithril-signer::era_switch ‑ test_extensions::certificate_handler::tests::retrieve_aggregator_features
mithril-signer::era_switch ‑ test_extensions::certificate_handler::tests::retrieve_epoch_settings

mithril-signer::create_cardano_transaction_single_signature ‑ test_extensions::fake_aggregator::tests::register_signer
mithril-signer::create_cardano_transaction_single_signature ‑ test_extensions::fake_aggregator::tests::retrieve_epoch_settings
mithril-signer::create_immutable_files_full_single_signature ‑ test_extensions::fake_aggregator::tests::register_signer
mithril-signer::create_immutable_files_full_single_signature ‑ test_extensions::fake_aggregator::tests::retrieve_epoch_settings
mithril-signer::era_switch ‑ test_extensions::fake_aggregator::tests::register_signer
mithril-signer::era_switch ‑ test_extensions::fake_aggregator::tests::retrieve_epoch_settings

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM 👍