-
Notifications
You must be signed in to change notification settings - Fork 51
Decentralization of configuration parameters phase 1 #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decentralization of configuration parameters phase 1 #2702
Conversation
Test Results 4 files ± 0 168 suites +4 24m 19s ⏱️ +31s Results for commit 0fb35d9. ± Comparison against base commit b7be57f. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
43f79ef to
b890de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
3682084 to
910faf9
Compare
0f0d971 to
d4a42de
Compare
683fd96 to
73af399
Compare
6c81af6 to
1a65b8c
Compare
1a65b8c to
6488a66
Compare
internal/mithril-protocol-config/src/http_client/aggregator_client.rs
Outdated
Show resolved
Hide resolved
…ork configuration
…uration'to improve understanding
…trations_from_aggregator' to improve understanding
…using dummy instead
…it from ticker_service
…oid duplicated test code
…t will be move latter in a dedicated crate
…truct to represent SignedEntityConfiguration to avoid inconsistent data
* mithril-signer from '0.2.270' to '0.2.271'
7e78976 to
0fb35d9
Compare
Content
Introduce a new crate called
mithril-protocol-configto retrieve information about the Mithril Network (like epoch settings and aggregator features).This crate contains a new trait,
MithrilNetworkConfigurationProvider, and a first implementation calling Aggregator REST API. (in the future, for the purpose of decentralization, a new implementation will be created reading the Cardanao chain).Crate
mithril-signeruse this new trait instead of using its internalAggregatorClient.Pre-submit checklist
Issue(s)
Relates to #2692 (mithril protocol config and signer parts)