Skip to content

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Sep 24, 2025

Content

Introduce a new crate called mithril-protocol-config to retrieve information about the Mithril Network (like epoch settings and aggregator features).

This crate contains a new trait, MithrilNetworkConfigurationProvider, and a first implementation calling Aggregator REST API. (in the future, for the purpose of decentralization, a new implementation will be created reading the Cardanao chain).

Crate mithril-signer use this new trait instead of using its internal AggregatorClient.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Relates to #2692 (mithril protocol config and signer parts)

@turmelclem turmelclem changed the title Ctl/2692 decentralization of configuration parameters phase 1 Decentralization of configuration parameters phase 1 Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Test Results

    4 files  ± 0    168 suites  +4   24m 19s ⏱️ +31s
2 227 tests +23  2 227 ✅ +23  0 💤 ±0  0 ❌ ±0 
6 879 runs  +92  6 879 ✅ +92  0 💤 ±0  0 ❌ ±0 

Results for commit 0fb35d9. ± Comparison against base commit b7be57f.

This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both.
mithril-signer ‑ runtime::runner::tests::test_inform_epoch_setting_pass_allowed_discriminant_to_epoch_service
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_500
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_json_serialization
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ok_200
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_timeout
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ko_500
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ok_200
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_timeout
mithril-protocol-config ‑ aggregator_client::tests::test_4xx_errors_are_handled_as_remote_server_logical
mithril-protocol-config ‑ aggregator_client::tests::test_5xx_errors_are_handled_as_remote_server_technical
mithril-protocol-config ‑ aggregator_client::tests::test_non_4xx_or_5xx_errors_are_handled_as_unhandled_status_code_and_contains_response_text
…

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 43f79ef to b890de0 Compare September 24, 2025 14:36
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 3682084 to 910faf9 Compare September 30, 2025 13:00
@turmelclem turmelclem self-assigned this Sep 30, 2025
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 3 times, most recently from 0f0d971 to d4a42de Compare September 30, 2025 15:24
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 2 times, most recently from 683fd96 to 73af399 Compare October 3, 2025 15:15
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch 5 times, most recently from 6c81af6 to 1a65b8c Compare October 6, 2025 16:02
@turmelclem turmelclem requested review from Alenar and jpraynaud October 6, 2025 16:04
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 1a65b8c to 6488a66 Compare October 6, 2025 16:18
…trations_from_aggregator' to improve understanding
…truct to represent SignedEntityConfiguration to avoid inconsistent data
* mithril-signer from '0.2.270' to '0.2.271'
@turmelclem turmelclem force-pushed the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch from 7e78976 to 0fb35d9 Compare October 13, 2025 09:14
@turmelclem turmelclem merged commit 69e39ed into main Oct 13, 2025
43 of 51 checks passed
@turmelclem turmelclem deleted the ctl/2692-decentralization-of-configuration-parameters-phase-1 branch October 13, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants