Skip to content

fix: docker client command in documentation #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

fix: docker client command in documentation #2695

merged 2 commits into from
Sep 16, 2025

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 16, 2025 •
edited
Loading

Content

This PR includes a fix in the client Docker command in the documentation website: by default the downloaded Cardano database was not restored in the mounted volume and thus inaccessible from the host machine.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

@jpraynaud
docs: fix client Docker command
e4d41cf 
Which was not downloading the restored Cardano database in the mounted volume by default.
@jpraynaud
docs: fix client Docker command in maintained version
429c44b 
Which was not downloading the restored Cardano database in the mounted volume by default.
@jpraynaud jpraynaud self-assigned this Sep 16, 2025
turmelclem
turmelclem approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results

    4 files  ±0    164 suites  ±0   23m 43s ⏱️ - 1m 16s
2 180 tests ±0  2 180 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 702 runs  ±0  6 702 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 429c44b. ± Comparison against base commit 3dfc782.

@jpraynaud jpraynaud merged commit 1f168d0 into main Sep 16, 2025
41 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-docker-client-command branch September 16, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turmelclem turmelclem turmelclem approved these changes

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpraynaud @turmelclem