-
Notifications
You must be signed in to change notification settings - Fork 52
fix: flakiness in e2e tests in the CI #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flakiness in e2e tests in the CI #2688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses flakiness in end-to-end tests when multiple clients verify Cardano databases concurrently by introducing timestamp-based temporary directory providers to prevent file system conflicts.
- Adds a new
TempDirectoryProvidertrait andTimestampTempDirectoryProviderimplementation for unique temporary directories - Updates the
CardanoDatabaseClientto use the new temporary directory provider instead of hardcoded paths - Refactors digest file handling to use instance-specific temporary directories
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mithril-client/src/utils/temp_dir_provider.rs | Introduces the TempDirectoryProvider trait and TimestampTempDirectoryProvider implementation |
| mithril-client/src/utils/mod.rs | Adds the new temp_dir_provider module to exports and reorganizes imports |
| mithril-client/src/client.rs | Integrates TimestampTempDirectoryProvider in the client constructor |
| mithril-client/src/cardano_database_client/proving.rs | Updates InternalArtifactProver to use the injected temp directory provider |
| mithril-client/src/cardano_database_client/api.rs | Updates CardanoDatabaseClient constructor and test infrastructure to accept temp directory provider |
| mithril-client/Cargo.toml | Bumps version from 0.12.30 to 0.12.31 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…h temporary folder provider
* mithril-client from `0.12.30` to `0.12.31`
Test Results 4 files ±0 164 suites ±0 23m 49s ⏱️ + 1m 14s Results for commit 42c8f9c. ± Comparison against base commit 6a7107e. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ab8e130 to
42c8f9c
Compare
turmelclem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Content
This PR includes a fix for flakiness in the e2e tests in the CI which occurs when multiple clients are verifying Cardano database concurrently.
Pre-submit checklist
Issue(s)
Closes #2687