Skip to content

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Sep 9, 2025

Content

This PR includes a new step in the test-client.yml github actions to check that cardano database v2 command verify from mithril-client-cli fails if there if missing and/or tampered immutable file(s) in the database to verify

the run remove and tampered specific immutable files from a previously downloaded database, run the verify command and then expect to find in the return error json file the exact list of missing and tampered files.

we also check that non-verifiable-files list is empty

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2678

@turmelclem turmelclem force-pushed the ctl/2678-add-verification-step-of-tampered-cardano-database-in-CI branch from 63a071b to 0ba187f Compare September 9, 2025 13:32
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Test Results

    4 files  ±0    164 suites  ±0   22m 24s ⏱️ -11s
2 180 tests ±0  2 180 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 702 runs  ±0  6 702 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 45f0d8b. ± Comparison against base commit 6a7107e.

♻️ This comment has been updated with latest results.

@turmelclem turmelclem self-assigned this Sep 9, 2025
@turmelclem turmelclem force-pushed the ctl/2678-add-verification-step-of-tampered-cardano-database-in-CI branch from d805d98 to 3f48057 Compare September 9, 2025 16:45
@turmelclem turmelclem force-pushed the ctl/2678-add-verification-step-of-tampered-cardano-database-in-CI branch 3 times, most recently from d456d5f to 4310827 Compare September 10, 2025 09:28
…abase to check for missing and tampered immutable files
@turmelclem turmelclem force-pushed the ctl/2678-add-verification-step-of-tampered-cardano-database-in-CI branch from 4310827 to 45f0d8b Compare September 10, 2025 09:32
@turmelclem turmelclem changed the title Execute cardano database v2 command verify on a invalid dat… add cardano db verify step in the CI that fails on expected tampered/missing files Sep 10, 2025
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem turmelclem marked this pull request as ready for review September 11, 2025 07:36
@turmelclem turmelclem merged commit de2a341 into main Sep 11, 2025
81 of 82 checks passed
@turmelclem turmelclem deleted the ctl/2678-add-verification-step-of-tampered-cardano-database-in-CI branch September 11, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add verification of a tampered Cardano database in the CI

3 participants