Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Aug 20, 2025

Content

This PR includes a fix to an issue that prevented to create new immutable files on the block producer Cardano nodes in the infrastructure with Cardano node 10.5.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2623

@jpraynaud jpraynaud self-assigned this Aug 20, 2025
@jpraynaud jpraynaud requested review from Copilot and rezabaram August 20, 2025 14:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a configuration issue preventing block producer Cardano nodes from creating new immutable files in the infrastructure with Cardano node version 10.5.

  • Adds processing for config-bp.json configuration files for block producer nodes
  • Updates Docker configuration to use the correct config-bp.json file instead of the generic config.json
  • Removes peerSnapshotFile property from topology configuration for block producer nodes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
mithril-infra/mithril.signer.tf Adds configuration processing for block producer config files and updates topology configuration
mithril-infra/assets/infra.version Updates infrastructure version from 0.4.8 to 0.4.9
mithril-infra/assets/docker/docker-compose-signer-cardano-bp-override.yaml Changes config file reference from config.json to config-bp.json

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Test Results

    4 files  ±0    158 suites  ±0   23m 43s ⏱️ + 1m 8s
2 152 tests ±0  2 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 602 runs  ±0  6 602 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6a25bf. ± Comparison against base commit d10fa1f.

@jpraynaud jpraynaud merged commit 7ec438a into main Aug 20, 2025
42 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2623-fix-block-producer-infra branch August 20, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants