Skip to content

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 30, 2025

Content

This PR includes a fix to the one-line installer script to ensure the provided install path is writable before proceeding. This avoids misleading errors when the path is not writable.
The creation of the install path directory has also been moved after the command-line argument parsing step to avoid attempting to create a directory with an undefined value.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

@dlachaume dlachaume self-assigned this Jul 30, 2025
@github-actions
Copy link

github-actions bot commented Jul 30, 2025

Test Results

    4 files  ±0    154 suites  ±0   22m 49s ⏱️ -48s
2 121 tests ±0  2 121 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 478 runs  ±0  6 478 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 08d4683. ± Comparison against base commit a776b3d.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview July 30, 2025 09:42 — with GitHub Actions Inactive
Also moved the creation of the install path after argument parsing to avoid creating a directory with an undefined value.
@dlachaume dlachaume force-pushed the dlachaume/one-line-installer-install-path-writable branch from 0ee7753 to 08d4683 Compare July 30, 2025 09:43
@dlachaume dlachaume temporarily deployed to testing-preview July 30, 2025 09:56 — with GitHub Actions Inactive
@dlachaume dlachaume requested review from Alenar and turmelclem July 30, 2025 10:37
@dlachaume dlachaume merged commit cdc4548 into main Jul 30, 2025
41 checks passed
@dlachaume dlachaume deleted the dlachaume/one-line-installer-install-path-writable branch July 30, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants