chore: add dev adr for guidelines on writting test utilities + remove test_tools and full features from mithril-common
#2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
added
refactoring 🛠️
There was a problem hiding this comment.
Pull Request Overview
This PR removes the test_tools and full features from mithril-common and adds guidelines for organizing test utilities, aimed at enhancing Rust compiler artifact reuse and reducing build times.
- Remove
test_toolsandfullfeature flags frommithril-commonto simplify feature management - Update all dependent crates to remove references to these features
- Add new Dev ADR guidelines for organizing crate test utilities
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mithril-common/Cargo.toml | Remove test_tools and full feature definitions |
| mithril-common/src/lib.rs | Remove feature gates from test module |
| mithril-common/src/entities/block_range.rs | Remove feature gate from test_extensions module |
| mithril-common/src/crypto_helper/cardano/key_certification.rs | Remove feature gate from test_extensions module |
| mithril-common/Makefile | Remove feature checking infrastructure |
| Multiple Cargo.toml files | Remove test_tools and full feature references from dependencies |
| DEV-ADR.md | Add new guidelines for organizing test utilities |
Alenar
force-pushed
the
djo/2580/test-structure-adr+remove-test_tools_flag
branch
2 times, most recently
from
7bf987e to
20cfc71
Compare
dlachaume
approved these changes
Jul 25, 2025
Collaborator
Author
|
Todo:
|
Alenar
force-pushed
the
djo/2580/test-structure-adr+remove-test_tools_flag
branch
from
20cfc71 to
2839572
Compare
This limit the available features of `mithril-common` to a minimum, making it easier for rust compiler to reuse build artifacts.
* mithril-cardano-node-chain from `0.1.6` to `0.1.7` * mithril-cardano-node-internal-database from `0.1.4` to `0.1.5` * mithril-aggregator-client from `0.1.0` to `0.1.1` * mithril-dmq from `0.1.7` to `0.1.8` * mithril-era from `0.1.4` to `0.1.5` * mithril-metric from `0.1.18` to `0.1.19` * mithril-persistence from `0.2.58` to `0.2.59` * mithril-resource-pool from `0.0.7` to `0.0.8` * mithril-signed-entity-preloader from `0.0.9` to `0.0.10` * mithril-api-spec from `0.1.4` to `0.1.5` * mithril-aggregator from `0.7.80` to `0.7.81` * mithril-client-cli from `0.12.25` to `0.12.26` * mithril-client from `0.12.26` to `0.12.27` * mithril-common from `0.6.14` to `0.6.15` * mithril-relay from `0.1.49` to `0.1.50` * mithril-signer from `0.2.264` to `0.2.265` * mithril-end-to-end from `0.4.100` to `0.4.101`
jpraynaud
force-pushed
the
djo/2580/test-structure-adr+remove-test_tools_flag
branch
from
2839572 to
68a0017
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
approved these changes
Aug 19, 2025
jpraynaud
deleted the
djo/2580/test-structure-adr+remove-test_tools_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a new Dev-Adr entries, "Guidelines for crate test utilities", and remove the
test_toolsandfullfeatures frommithril-commonin order to enhance Rust compiler ability to reuse built artifacts.Pre-submit checklist
Issue(s)
Closes #2662, Relates to #2580