-
Notifications
You must be signed in to change notification settings - Fork 51
fix(dmq): add missing KES period in 'DmqMsg' #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1064600 to
d7f4e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the missing kes_period field to DmqMsg by:
- Including
kes_periodin the message ID hash computation. - Fetching and assigning the current KES period in
DmqMessageBuilder. - Updating tests and bumping the crate version.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/mithril-dmq/src/message.rs | Added kes_period hashing, builder logic, and test defaults |
| internal/mithril-dmq/src/consumer/pallas.rs | Updated test cases to include kes_period values |
| internal/mithril-dmq/Cargo.toml | Bumped version from 0.1.2 to 0.1.3 |
Comments suppressed due to low confidence (2)
internal/mithril-dmq/src/message.rs:145
- After introducing
kes_periodintocompute_msg_id, add a test verifying that twoDmqMsginstances with differentkes_periodvalues produce differentmsg_ids to ensure the new field is properly hashed.
kes_period: 0,
internal/mithril-dmq/Cargo.toml:4
- After bumping the crate version, update the CHANGELOG (or relevant release notes) to document the addition of the
kes_periodfield inDmqMsg.
version = "0.1.3"
* mithril-dmq from `0.1.2` to `0.1.3`
d7f4e35 to
841640e
Compare
dlachaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
turmelclem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Content
This PR includes a fix for the missing
kes_periodfield in theDmqMsgstruct following an update in the pallas crate.Pre-submit checklist
Issue(s)
Relates to #2627