Skip to content

Enhance STM library readability - Rename functions #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Enhance STM library readability - Rename functions #2632

merged 2 commits into from
Jul 8, 2025

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Jul 4, 2025 •
edited
Loading

Content

This PR renames function names in STM library.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2568

@github-actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

Test Results

    4 files  ±0    154 suites  ±0   21m 21s ⏱️ -14s
2 079 tests ±0  2 079 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 386 runs  ±0  6 386 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f5f021c. ± Comparison against base commit 46802f0.

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt temporarily deployed to testing-preview July 4, 2025 14:10 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Jul 4, 2025
View reviewed changes
@curiecrypt curiecrypt temporarily deployed to testing-preview July 4, 2025 14:58 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 4, 2025
View reviewed changes
jpraynaud
jpraynaud reviewed Jul 7, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 7, 2025
View reviewed changes
@curiecrypt curiecrypt force-pushed the curiecrypt/rename-functions branch from d80a0e7 to 637f515 Compare July 7, 2025 13:24
jpraynaud
jpraynaud approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@curiecrypt curiecrypt requested a review from jpraynaud July 8, 2025 14:53
@curiecrypt curiecrypt marked this pull request as ready for review July 8, 2025 14:59
@curiecrypt curiecrypt temporarily deployed to testing-preview July 8, 2025 15:02 — with GitHub Actions Inactive
@curiecrypt curiecrypt force-pushed the curiecrypt/rename-functions branch from a1fff48 to f5f021c Compare July 8, 2025 15:13
@curiecrypt curiecrypt temporarily deployed to testing-preview July 8, 2025 15:28 — with GitHub Actions Inactive
@curiecrypt curiecrypt merged commit b7a272c into main Jul 8, 2025
41 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/rename-functions branch July 8, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud Awaiting requested review from jpraynaud

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@curiecrypt @jpraynaud