Skip to content

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 3, 2025

Content

This PR includes individual formatting of files not detected by cargo fmt (likely due to the code being located inside macros), and updates the rustfmt.toml configuration to use style_edition = "2024" as recommended in the documentation.

Here is a command line to automatically fix these inconsistencies:

find . -type f -name "*.rs" -not -path "./target/*" -exec rustfmt {} --edition 2024 \;

Below is the list of files ignored:

mithril-client/src/cardano_database_client/download_unpack/download_task.rs
mithril-client/src/cardano_database_client/download_unpack/download_unpack_options.rs
mithril-client/src/cardano_database_client/download_unpack/internal_downloader.rs
mithril-client/src/cardano_database_client/download_unpack/mod.rs
mithril-client/src/cardano_database_client/immutable_file_range.rs
mithril-client/src/cardano_database_client/proving.rs
mithril-client/src/file_downloader/http.rs
mithril-client/src/file_downloader/interface.rs
mithril-client/src/file_downloader/mock_builder.rs
mithril-client/src/file_downloader/mod.rs
mithril-client/src/file_downloader/retry.rs
mithril-client/src/utils/ancillary_verifier.rs
mithril-client/src/utils/bootstrap_files.rs
mithril-client/src/utils/fs.rs
mithril-client/src/utils/stream_reader.rs
mithril-client/src/utils/unexpected_downloaded_file_verifier.rs
mithril-client/src/utils/vec_deque_extensions.rs
mithril-common/src/certificate_chain/fake_certificate_retriever.rs
mithril-common/src/crypto_helper/cardano/kes/signer_fake.rs
mithril-common/src/crypto_helper/cardano/kes/tests_setup.rs
mithril-common/src/crypto_helper/tests_setup.rs
mithril-common/src/test_utils/cardano_transactions_builder.rs
mithril-common/src/test_utils/certificate_chain_builder.rs
mithril-common/src/test_utils/dir_eq.rs
mithril-common/src/test_utils/fake_data.rs
mithril-common/src/test_utils/fake_keys.rs
mithril-common/src/test_utils/fixture_builder.rs
mithril-common/src/test_utils/memory_logger.rs
mithril-common/src/test_utils/mithril_fixture.rs
mithril-common/src/test_utils/mock_extensions.rs
mithril-common/src/test_utils/mod.rs
mithril-common/src/test_utils/precomputed_kes_key.rs
mithril-common/src/test_utils/temp_dir.rs

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Relates to #2582

@dlachaume dlachaume self-assigned this Jul 3, 2025
@dlachaume dlachaume marked this pull request as ready for review July 3, 2025 13:18
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Test Results

    4 files  ±0    154 suites  ±0   22m 14s ⏱️ -6s
2 071 tests ±0  2 071 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 356 runs  ±0  6 356 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 630eb02. ± Comparison against base commit a6d5487.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the dlachaume/2582/fix-cargo-fmt-ignore-files branch from 03570fc to c9b53a7 Compare July 3, 2025 13:21
 name = "client-cardano-database-v2" -version = "0.0.10" +version = "0.0.11" * client-cardano-database from `0.1.34` to `0.1.35`
* mithril-client from `0.12.19` to `0.12.20`
* mithril-common from `0.6.6` to `0.6.7`
@dlachaume dlachaume force-pushed the dlachaume/2582/fix-cargo-fmt-ignore-files branch from 7bc8e40 to 630eb02 Compare July 3, 2025 13:27
@dlachaume dlachaume temporarily deployed to testing-preview July 3, 2025 13:37 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 81d08dc into main Jul 3, 2025
41 checks passed
@dlachaume dlachaume deleted the dlachaume/2582/fix-cargo-fmt-ignore-files branch July 3, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants