Skip to content

Minimum supported Cardano node versions for Mithril signers #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2024
Merged

Minimum supported Cardano node versions for Mithril signers #1624

merged 5 commits into from
Apr 15, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Apr 9, 2024 •
edited
Loading

Content

This PR includes a new file networks.json at the root of the repository.
It contains the list of the minimum supported Cardano node versions for each network.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1615

@dlachaume dlachaume self-assigned this Apr 9, 2024
@github-actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   8m 44s ⏱️ +30s
  915 tests ±0    915 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 009 runs  ±0  1 009 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fa2114e. ± Comparison against base commit 0e40969.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview April 9, 2024 16:00 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 9, 2024 16:00 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 2e6c8bc to 9eee2d8 Compare April 9, 2024 17:50
@dlachaume dlachaume temporarily deployed to testing-preview April 9, 2024 17:57 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 9, 2024 17:57 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 9eee2d8 to f37b64a Compare April 10, 2024 07:27
@dlachaume dlachaume temporarily deployed to testing-preview April 10, 2024 07:50 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 10, 2024 07:50 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 10, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from f37b64a to 61f152a Compare April 10, 2024 17:37
@dlachaume dlachaume temporarily deployed to testing-preview April 10, 2024 17:47 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 10, 2024 17:47 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Few modifications to be done before merging

dlachaume added a commit that referenced this pull request Apr 11, 2024
@dlachaume
[WIP] Update after final review
fee2aa2 
- One last comment to address: #1624 (comment)
@dlachaume dlachaume temporarily deployed to testing-preview April 11, 2024 12:14 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 11, 2024 12:14 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from fee2aa2 to 15db78f Compare April 12, 2024 09:05
@dlachaume dlachaume temporarily deployed to testing-preview April 12, 2024 09:13 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 12, 2024 09:13 — with GitHub Actions Inactive
@TrevorBenson TrevorBenson mentioned this pull request Apr 14, 2024
Closed
5 tasks
@dlachaume dlachaume temporarily deployed to testing-preview April 15, 2024 08:44 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 15, 2024 08:44 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 15, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from b1e6693 to 3ab85ad Compare April 15, 2024 10:03
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 3ab85ad to cc50e41 Compare April 15, 2024 10:03
jpraynaud
jpraynaud reviewed Apr 15, 2024
View reviewed changes
jpraynaud
jpraynaud reviewed Apr 15, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 645026b to 1dc812a Compare April 15, 2024 10:27
@dlachaume dlachaume temporarily deployed to testing-preview April 15, 2024 10:34 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 15, 2024 10:34 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 15, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 1dc812a to afb7f0b Compare April 15, 2024 12:59
@dlachaume dlachaume temporarily deployed to testing-preview April 15, 2024 13:12 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 15, 2024 13:12 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from 868132e to afb7f0b Compare April 15, 2024 13:14
@dlachaume dlachaume temporarily deployed to testing-preview April 15, 2024 13:20 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 15, 2024 13:20 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1615/add-cardano-minimum-version-file branch from afb7f0b to fa2114e Compare April 15, 2024 13:58
jpraynaud
jpraynaud approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-preview April 15, 2024 14:05 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 15, 2024 14:05 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit fa9e594 into main Apr 15, 2024
@dlachaume dlachaume deleted the damien/1615/add-cardano-minimum-version-file branch April 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create file with Cardano minimum versions in repository

4 participants

@dlachaume @Alenar @jpraynaud