-
Notifications
You must be signed in to change notification settings - Fork 78
[ETCM-829] rewrite healthcheck #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dzajkowski
reviewed
May 12, 2021
src/main/scala/io/iohk/ethereum/jsonrpc/NodeJsonRpcHealthChecker.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
May 12, 2021
src/main/scala/io/iohk/ethereum/jsonrpc/NodeJsonRpcHealthChecker.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
May 12, 2021
src/main/scala/io/iohk/ethereum/jsonrpc/NodeJsonRpcHealthChecker.scala
Outdated
Show resolved
Hide resolved
dzajkowski
approved these changes
May 12, 2021
Contributor
dzajkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a few small comments
src/test/scala/io/iohk/ethereum/jsonrpc/server/http/JsonRpcHttpServerSpec.scala
Outdated
Show resolved
Hide resolved
94c824a to
7e61707
Compare
leo-bogastry
approved these changes
May 20, 2021
e26a38b to
05be6c8
Compare
- adds predicate to existing health checks - Adds a way to set additional info in the healthcheck - Adds updateStatus - Check if the server seems stuck for too long - Adds syncStatus
05be6c8 to
4382059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrite the healthcheck endpoint to have more precise info :
It can still be improved by returning the number of healthy peers instead of the raw number of peers.
Important Changes Introduced
The healthcheck endpoint is not backward compatible (for instance I renamed the field
descriptiontonamebecause it seems more accurate)two new parameters :
mantis.network.rpc.http.health.no-update-duration-thresholdmantis.network.rpc.http.health.syncing-status-thresholdThe values of some parameters are given as a generic parameter "info" which is a string. I think it is alright for a healthcheck endpoint but we might want to consider if we want something more strongly typed.
Testing
You can call
<node_url>/healthcheckto see the endpoint, and check that it moves correctlyThe result should look like this :