[ETCM-814] Don't burn part of the rewards that would go to treasury #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsuieric
force-pushed
the
feature/ETCM-814-no-rewards-burned
branch
2 times, most recently
from
5127a4f to
439a7a3
Compare
leo-bogastry
approved these changes
May 6, 2021
Contributor
|
looks like the fast sync validator is covered ( |
dzajkowski
force-pushed
the
feature/ETCM-814-no-rewards-burned
branch
3 times, most recently
from
ea4c4d9 to
54a4f63
Compare
dzajkowski
changed the title
Contributor
|
👍 |
src/main/scala/io/iohk/ethereum/consensus/validators/BlockHeaderValidator.scala
Outdated
Show resolved
Hide resolved
dzajkowski
force-pushed
the
feature/ETCM-814-no-rewards-burned
branch
from
54a4f63 to
00d7c10
Compare
AurelienRichez
approved these changes
May 14, 2021
dzajkowski
force-pushed
the
feature/ETCM-814-no-rewards-burned
branch
from
00d7c10 to
43a58f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A miner should no longer be able to burn part of its reward that would be sent to the treasury. Change proposal ECIP 1098.
Proposed Solution
Code responsible with burning the rewards is removed.
Miner opting out of sending the rewards to treasury is not possible anymore.
Added block header validation that check treasuryOptOut for invalid blocks
Important Changes Introduced
Added block header validation that check treasuryOptOut for invalid blocks
Testing
added unit tests, sync with sagano