ETCM-389 Move checkpoint creation to the checkpoint service #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajkowski
reviewed
Mar 29, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Outdated
Show resolved
Hide resolved
dzajkowski
approved these changes
Mar 29, 2021
leo-bogastry
approved these changes
Mar 30, 2021
Contributor
leo-bogastry
left a comment
leo-bogastry
left a comment
There was a problem hiding this comment.
Nice to see the block handling simplified!
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Outdated
Show resolved
Hide resolved
AnastasiiaL
force-pushed
the
feature/ETCM-389-handle-blocks-uniformly
branch
from
d56eca6 to
7fe6254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkpoint creation moved to a respective service, so checkpoints and mined blocks are handled uniformly