Skip to content

Conversation

@manveru
Copy link
Contributor

@manveru manveru commented Mar 26, 2021

Description

A clear and concise description of what this pull request does or fixes.

Proposed Solution

Optional Explain how does this PR solves the problem stated in Description. You can also enumerate different alternatives considered while approaching this task.

Important Changes Introduced

Optional Notice Reviewers about changes that were introduced while developing this task

Testing

Optional Leave some recommendations should be useful while reviewers are testing this PR

@manveru manveru requested review from jonringer and ten15bit March 26, 2021 21:08
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manveru manveru force-pushed the fix-update-nix branch 5 times, most recently from 3037c96 to 9514770 Compare March 31, 2021 08:21
Copy link
Contributor

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ten15bit ten15bit merged commit fdeb1c3 into develop Mar 31, 2021
@dzajkowski dzajkowski deleted the fix-update-nix branch April 9, 2021 12:00
bsuieric pushed a commit that referenced this pull request Apr 13, 2021
* fix the update-nix script

* insert mantis-extvm-pb into the build instead of using submodules

* disable darwin builds because solc fails

* rely on depsSha256 instead of a hack

* another try to fix hash generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants