ETCM-147 use explicitly triggered scheduler for SyncControllerSpec #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdp
force-pushed
the
feature/ETCM-147-improve-synccontrollerspec
branch
from
ec7cdfa to
1e67007
Compare
ten15bit
approved these changes
Feb 4, 2021
src/test/scala/io/iohk/ethereum/blockchain/sync/SyncControllerSpec.scala
Outdated
Show resolved
Hide resolved
jvdp
force-pushed
the
feature/ETCM-147-improve-synccontrollerspec
branch
from
c82150b to
04fc825
Compare
ten15bit
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actors used by
SyncControlleruse the scheduler to retry various actions and its tests rely on this behavior to trigger, which involves retrying over period of up to 10 or 30 seconds. By using an explicitly triggered scheduler we can instead advance the clock artificially and only a short time.Because of the complexity of the actors and the different timeouts I had to find the time steps (100ms and 3000ms) by trial and error, unfortunately. If they are too high or too low the specs will fail. In addition, the speed up is only about 2-4x.