[FIX] Not starting miner #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquerodbe
approved these changes
Dec 30, 2020
lemastero
approved these changes
Dec 30, 2020
biandratti
approved these changes
Dec 30, 2020
|
|
||
| override def askMiner(msg: MinerProtocol): Task[MinerResponse] = { | ||
| atomicMiner | ||
| .get() |
Contributor
There was a problem hiding this comment.
I would fix the situation with get() and then...
| case Ethash | RestrictedEthash => EthashMiner(node) | ||
| case MockedPow => MockedMiner(node) | ||
| } | ||
| atomicMiner.set(Some(miner)) |
Contributor
There was a problem hiding this comment.
... and then set a miner. Because it is possible to set a miner in between of those.
Contributor
Author
There was a problem hiding this comment.
@dmitry-worker could you elaborate more?
Contributor
There was a problem hiding this comment.
There is already PR opened that intend to fix that: #777
There is no conclusion of the solution proposed there is the right one.
The change proposed here is an important fix. IMHO it is better to merge it and deal with potential concurrency issue in PR ☝️ .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, askFor method is designed for sending a message to the actor and waiting for the response. Also, Task was used.
SendMiner prepared to communicate with Miner is using askFor, but not every usage should wait for the response and not every usage was executing task.
Important Changes Introduced
Testing
run and check if miner is starting