[ETCM-266]-replaced-rate-limiter-built-on-twitter #873
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,71 @@ | ||
| package io.iohk.ethereum.jsonrpc.server.http | ||
|
|
||
| import java.time.Duration | ||
|
|
||
| import akka.NotUsed | ||
| import akka.http.scaladsl.model.{RemoteAddress, StatusCodes} | ||
| import akka.http.scaladsl.server.{Directive0, Route} | ||
| import io.iohk.ethereum.jsonrpc.server.http.JsonRpcHttpServer.RateLimitConfig | ||
| import akka.http.scaladsl.server.Directives._ | ||
| import com.google.common.base.Ticker | ||
| import com.google.common.cache.CacheBuilder | ||
| import io.iohk.ethereum.jsonrpc.JsonRpcError | ||
| import de.heikoseeberger.akkahttpjson4s.Json4sSupport | ||
| import io.iohk.ethereum.jsonrpc.serialization.JsonSerializers | ||
| import org.json4s.{DefaultFormats, Formats, Serialization, native} | ||
|
|
||
| class RateLimit(config: RateLimitConfig) extends Directive0 with Json4sSupport { | ||
|
|
||
| private implicit val serialization: Serialization = native.Serialization | ||
| private implicit val formats: Formats = DefaultFormats + JsonSerializers.RpcErrorJsonSerializer | ||
|
|
||
| private[this] lazy val minInterval = config.minRequestInterval.toSeconds | ||
|
|
||
| private[this] lazy val lru = { | ||
| val nanoDuration = config.minRequestInterval.toNanos | ||
| val javaDuration = Duration.ofNanos(nanoDuration) | ||
| val ticker: Ticker = new Ticker { | ||
| override def read(): Long = getCurrentTimeNanos | ||
| } | ||
| CacheBuilder | ||
| .newBuilder() | ||
| .weakKeys() | ||
| .expireAfterAccess(javaDuration) | ||
| .ticker(ticker) | ||
| .build[RemoteAddress, NotUsed]() | ||
| } | ||
|
|
||
| private[this] def isBelowRateLimit(ip: RemoteAddress): Boolean = { | ||
| var exists = true | ||
| lru.get( | ||
| ip, | ||
| () => { | ||
| exists = false | ||
| NotUsed | ||
| } | ||
| ) | ||
| exists | ||
| } | ||
|
|
||
| // Override this to test | ||
| protected def getCurrentTimeNanos: Long = System.nanoTime() | ||
|
|
||
| // Such algebras prevent if-elseif-else boilerplate in the JsonRPCServer code | ||
| // It is also guaranteed that: | ||
| // 1) no IP address is extracted unless config.enabled is true | ||
| // 2) no LRU is created unless config.enabled is true | ||
| // 3) cache is accessed only once (using get) | ||
| override def tapply(f: Unit => Route): Route = { | ||
| if (config.enabled) { | ||
| extractClientIP { ip => | ||
| if (isBelowRateLimit(ip)) { | ||
| val err = JsonRpcError.RateLimitError(minInterval) | ||
| complete((StatusCodes.TooManyRequests, err)) | ||
|
Contributor
There was a problem hiding this comment. Just a minor comment, we can reduce this line:
Contributor
Author
There was a problem hiding this comment. Actually it was inline in the beginning, but I've decided that the code is quite unreadable :) |
||
| } else { | ||
| f.apply(()) | ||
| } | ||
| } | ||
| } else f.apply(()) | ||
| } | ||
|
|
||
biandratti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.