[ETCM-468] add JSON-RPC method eth-getProof #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemastero
changed the title
Contributor
There was a problem hiding this comment.
PR's looking good!
But if I would upgrade something - maybe I'd upgrade the testing
- add at least one failed scenario - to be sure that error matches an expected one (3 error cases were defined)
- maybe test the route itself, mocking the logic - in order to validate
jsonit gives
src/test/scala/io/iohk/ethereum/jsonrpc/EthProofServiceSpec.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Would it make sense to have the happy path merged into dev and work on the rest in a separate PR? |
AnastasiiaL
reviewed
Jan 13, 2021
src/test/scala/io/iohk/ethereum/mpt/MerklePatriciaTrieSuite.scala
Outdated
Show resolved
Hide resolved
lemastero
changed the title
Contributor
Author
I have added sth like that in: dfd4ec3
Each we could use more tests. Let's add it as separate PR. WDYT? |
AnastasiiaL
reviewed
Jan 14, 2021
src/test/scala/io/iohk/ethereum/jsonrpc/EthProofServiceSpec.scala
Outdated
Show resolved
Hide resolved
dzajkowski
requested changes
Jan 14, 2021
src/main/scala/io/iohk/ethereum/jsonrpc/EthJsonMethodsImplicits.scala
Outdated
Show resolved
Hide resolved
src/test/scala/io/iohk/ethereum/jsonrpc/EthProofServiceSpec.scala
Outdated
Show resolved
Hide resolved
AnastasiiaL
reviewed
Jan 15, 2021
src/test/scala/io/iohk/ethereum/mpt/MerklePatriciaTrieSuite.scala
Outdated
Show resolved
Hide resolved
bsuieric
reviewed
Jan 18, 2021
Contributor
|
@AnastasiiaL @bsuieric would it be possible to bring this pr to a mergeable state and get it into dev? it's already large, further work can happen in separate PRs. WDYT? |
Contributor
the PR is ready to be merged, waiting for approval |
Contributor
|
How can I approve the PR? |
bsuieric
approved these changes
Jan 18, 2021
Contributor
|
done |
dzajkowski
approved these changes
Jan 19, 2021
added 7 commits
January 19, 2021 20:46
…], skeleton for methods getStorageProof, getAccountProof
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
…orage proof (real tests for proof are on MPT) Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
… request is handled by refactor Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
lemastero
force-pushed
the
feature/ETCM-468-eth-getProof
branch
from
bb80baa to
0b66389
Compare
added 2 commits
January 20, 2021 01:02
Signed-off-by: Piotr Paradziński <[email protected]>
Signed-off-by: Piotr Paradziński <[email protected]>
biandratti
pushed a commit
that referenced
this pull request
Jan 20, 2021
[ETCM-468] add eth_getProof JSON-RPC endpoint (without non-membership proofs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add eth_getProof JSON-RPC method. EIP-1186
Proposed Solution
Uses getProof implemented in #857.
Testing