Skip to content

Conversation

@dmitry-worker
Copy link
Contributor

Description

Unused snappy tests package had to be removed according to backlog task.

Proposed Solution

Remove the folder itself
Cleanup the build.sbt file

Copy link
Contributor

@lemastero lemastero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the commits?

Copy link
Contributor

@kapke kapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any unused dependencies maybe?

@dmitry-worker
Copy link
Contributor Author

Could you sign the commits?

I have actually signed the commit:

commit e92cbca30a8ccb235c8b65f07f42a7db3abd5b61 (HEAD -> feature/ETCM-349-remove-snappy-tests, origin/feature/ETCM-349-remove-snappy-tests)
gpg: Signature made Чт 17 дек 2020 21:00:09 MSK
gpg:                using RSA key 8EE1555B94AA9859824B7AF218F811D7C7A881A7
gpg: Good signature from "Dmitry Voronov <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 8EE1 555B 94AA 9859 824B  7AF2 18F8 11D7 C7A8 81A7
Author: dmitry-worker <[email protected]>
Date:   Thu Dec 17 21:00:09 2020 +0300

    feat - remove snappy test package along with it's build.sbt record

Copy link
Contributor

@enriquerodbe enriquerodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you signed the commits but GitHub says Unverified because you have to add your public key to your GitHub account?

@dmitry-worker
Copy link
Contributor Author

I think you signed the commits but GitHub says Unverified because you have to add your public key to your GitHub account?

Yep, and also commit was NOT under iohk email :( too bad for me

@dmitry-worker dmitry-worker force-pushed the feature/ETCM-349-remove-snappy-tests branch from e92cbca to f877bc3 Compare December 18, 2020 13:51
@dmitry-worker
Copy link
Contributor Author

dmitry-worker commented Dec 18, 2020

Are there any unused dependencies maybe?

@kapke I guess not, the library itself is gonna be used further.

@dmitry-worker dmitry-worker force-pushed the feature/ETCM-349-remove-snappy-tests branch 4 times, most recently from fcf6825 to d966294 Compare December 18, 2020 15:51
@dmitry-worker dmitry-worker force-pushed the feature/ETCM-349-remove-snappy-tests branch from d966294 to 1431946 Compare December 19, 2020 22:15
@dmitry-worker dmitry-worker merged commit 800d889 into develop Dec 20, 2020
@dzajkowski dzajkowski deleted the feature/ETCM-349-remove-snappy-tests branch April 9, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants