-
Notifications
You must be signed in to change notification settings - Fork 78
[ETCM-349] remove snappy test package along with it's build.sbt record #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lemastero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sign the commits?
kapke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any unused dependencies maybe?
I have actually signed the commit: |
enriquerodbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you signed the commits but GitHub says Unverified because you have to add your public key to your GitHub account?
Yep, and also commit was NOT under iohk email :( too bad for me |
e92cbca to
f877bc3
Compare
@kapke I guess not, the library itself is gonna be used further. |
fcf6825 to
d966294
Compare
d966294 to
1431946
Compare
Description
Unused
snappytests package had to be removed according to backlog task.Proposed Solution
Remove the folder itself
Cleanup the
build.sbtfile