Skip to content

Conversation

@ntallar
Copy link

@ntallar ntallar commented Dec 4, 2020

Description

Measure block execution metrics on reorg as well.

The current measuring point is only part of the possible paths of blocks execution, meaning that some imported blocks are currently not measured

@ntallar ntallar requested a review from pslaski December 4, 2020 18:38
@ntallar ntallar added the high priority This PRs should be reviewed and merged ASAP label Dec 4, 2020
Copy link
Contributor

@SoseMagarian SoseMagarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pslaski pslaski merged commit 94d108e into develop Dec 7, 2020
@pslaski pslaski deleted the fix/checkpointing-metrics branch December 7, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority This PRs should be reviewed and merged ASAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants