Skip to content

Conversation

@biandratti
Copy link
Contributor

@biandratti biandratti commented Dec 4, 2020

Description

  • We change the handler exception from rate limit.
  • backoff_seconds: represent the limit between requests from the same ip.
  • Fix logger logic when we have rate limit exceptions.

Status code: 429
{
"code": -32005,
"message": "request rate exceeded",
"data": {
"backoff_seconds": 10
}
}

Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP 

Though let me talk with devops regarding deploying this (I wouldn't merge it till then)

Copy link
Contributor

@SoseMagarian SoseMagarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntallar ntallar merged commit 07e617c into develop Dec 4, 2020
@ntallar ntallar deleted the feature-rate-limit-exception branch December 4, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants