[ETCM-396] faucet timeout #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-396-faucet-timeout
…-396-faucet-timeout
…-396-faucet-timeout
lemastero
approved these changes
Dec 3, 2020
Contributor
lemastero
left a comment
lemastero
left a comment
There was a problem hiding this comment.
LGTM 👍 This is a change in config. Probably worth to announce on proper channels.
ntallar
requested changes
Dec 4, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
Minor comment and LGTM! I'll create the corresponding PR on devops side and we'll discuss with them about re-deploying it
| with Logger { | ||
|
|
||
| implicit lazy val actorTimeout: Timeout = Timeout(config.responseTimeout) | ||
| implicit lazy val actorTimeout: Timeout = Timeout(config.responseTimeout + config.rpcClient.timeout) |
There was a problem hiding this comment.
It's a bit confusing having responseTimeout and rpcClient.timeout... maybe we should rename the first to actorCommunicationMargin or something like that?
Contributor
Author
There was a problem hiding this comment.
Right, I can change the property too, with the same name “actor-communication-margin”.
ntallar
approved these changes
Dec 4, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed Solution
For default the rpc client used the idle-timeout, that represents 60 seconds. So, now we can set this configuration.
When the actor FaucetHandler calls the node through the client rpc, now set a timeout of the request, represented by “rpc-client.timeout”.
So, when the class “FaucetRpcService” calls the actor “FaucetHandler” set a timeout represented for the sum “response-timeout” (actor resolve) + “rpc-client.timeout” (rpc client resolve).
When we have a timeout between the faucet and the node, in re response we receive the next message: "Faucet error: RPC request timeout"
Testing
If you want to reproduce this case, you can set rpc-client.timeout with 1.milliseconds for example.