[FIX] Handle timeouts on BlockFetcher #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntallar
force-pushed
the
fix/handle-timeout-blockfetcher
branch
2 times, most recently
from
fffb27b to
548de95
Compare
ntallar
force-pushed
the
fix/handle-timeout-blockfetcher
branch
from
548de95 to
dad4062
Compare
biandratti
reviewed
Nov 20, 2020
|
|
||
| implicit val ec: ExecutionContext = context.dispatcher | ||
| implicit val timeout: Timeout = syncConfig.peerResponseTimeout + 1.second // some margin for actor communication | ||
| implicit val timeout: Timeout = syncConfig.peerResponseTimeout + 2.second // some margin for actor communication |
Contributor
There was a problem hiding this comment.
Add value if we put this time margin as config?
Author
There was a problem hiding this comment.
Hmm would we ever want to change this again? Maybe we could have a general mantis configuration of akka ask timeout margins (as we are using this 2 seconds in other places)
Either way I'd do that on a separate task
biandratti
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address forking issue on the testnet
Scenario
During the startup of the nomad cluster there were some connectivity problems and some connections got closed resulting in timeouts on the requests. However for mantis-5
fetching headers == trueProposed Solution
Recover from ask pattern timeout on the BlockFetcher by using the error fallback, which results in the request being cancelled and a new one triggered
Testing
Added unit test