Skip to content

Conversation

@KonradStaniec
Copy link
Contributor

Description

Add some metrics to fast syncing

@KonradStaniec KonradStaniec requested review from a user and mmrozek November 17, 2020 12:47
def measure(syncState: SyncState): Unit = {
PivotBlockNumberGauge.set(syncState.pivotBlock.number.toDouble)
BestFullBlockNumberGauge.set(syncState.lastFullBlockNumber.toDouble)
BestFullBlockNumberGauge.set(syncState.bestBlockHeaderNumber.toDouble)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be BestHeaderNumberGauge

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Besides of that LGTM

@KonradStaniec KonradStaniec force-pushed the etcm-335/fast-sync-metrics branch from ed3d37e to 8d177b7 Compare November 17, 2020 13:59
Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KonradStaniec KonradStaniec merged commit df2916b into develop Nov 18, 2020
@ghost ghost deleted the etcm-335/fast-sync-metrics branch November 18, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants