Skip to content

[ETCM-341] faucet - revert configs #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

[ETCM-341] faucet - revert configs #791

merged 1 commit into from
Nov 12, 2020

Conversation

@biandratti
Copy link
Contributor

@biandratti biandratti commented Nov 12, 2020

Description

  • Revert Faucet's port from 8547 to default 8099.
  • Remove legacy cors, used in the httpserver removed. Today the current cors used is “mantis.network.http.cors-allowed-origins” into the faucet config

@biandratti biandratti added the bug Something isn't working label Nov 12, 2020
ntallar
ntallar approved these changes Nov 12, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP

@biandratti biandratti merged commit 33a24dc into develop Nov 12, 2020
@biandratti biandratti deleted the ETCM-341-faucet-config-rpc branch November 12, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntallar ntallar ntallar approved these changes

@lemastero lemastero Awaiting requested review from lemastero

@mirkoAlic mirkoAlic Awaiting requested review from mirkoAlic

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@biandratti @ntallar