Skip to content

Conversation

@ntallar
Copy link

@ntallar ntallar commented Nov 6, 2020

Description

Propagation improvements required for the testnet

Proposed Solution

  • Changed max-xxx-peers configurations to match the other project. Note that the effect of them might be a bit unreliable due to our bad usage of them, this will be improved a bit with [ETCM-178] Disallow duplicated connections and connections to self #763
  • Increased branch-resolution-request-size to 30 to be more resilient to reorgs
  • Increased timestamp of the genesis block and it's difficulty, for the testnet to be closer to the 15 second target time per blocks. Without this, the difficult moved toward that direction, but it would take quite a while to reach there.
  • Removed validation of NewBlockHashes message so that know top is always updated when one is received, as is the case with NewBlock messages

Copy link
Contributor

@mirkoAlic mirkoAlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirkoAlic mirkoAlic merged commit cd1f83c into develop Nov 6, 2020
@mirkoAlic mirkoAlic deleted the fix-propagation-improvements branch November 6, 2020 18:30
kapke pushed a commit that referenced this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants