[ETCM-301] Fix block preparation #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // // this seems to discard failures, for better errors messages we might want to implement a different method (simulateBlock?) | ||
| // val result = blockPreparator.prepareBlock(block) | ||
| // Right(result.blockResult.receipts) | ||
| // FIXME DO WE NEED THAT? |
Contributor
There was a problem hiding this comment.
Maybe we could create task to delete those snappy tests? (I highly doubt anybody will ever use it)
Contributor
Author
There was a problem hiding this comment.
Good idea. I just created https://jira.iohk.io/browse/ETCM-349
| * | ||
| * @param block the block with transactions to run | ||
| */ | ||
| private[ledger] def executeBlockTransactions(block: Block): Either[BlockExecutionError, BlockResult] = { |
Contributor
There was a problem hiding this comment.
maybe it would be possible to pass parent header here as param , to avoid this blockchain.getBlockHeaderByHash(block.header.parentHash ?
ntallar
requested changes
Nov 11, 2020
ntallar
requested changes
Nov 12, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
Apart from the below comments, LGTM!
Do you think there's any test that could be added for any of the two issues?
src/main/scala/io/iohk/ethereum/consensus/ethash/MockedMiner.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ntallar I don't think that we are able to add some reliable test to check that. I can't imagine any |
ntallar
approved these changes
Nov 13, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
KonradStaniec
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stateRootfromOptiontoByteStringinWorldStateProxyto avoid mistakesprepareBlockmethod.This change should also solve the issue described in ETCM-329