Skip to content

[FIX] Fix the way AsyncConfig is built #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

[FIX] Fix the way AsyncConfig is built #765

merged 1 commit into from
Oct 29, 2020

Conversation

@kapke
Copy link
Contributor

@kapke kapke commented Oct 29, 2020

Description

Async config was built improperly causing to node to fail

Testing

Run the node - it should not break now.

@kapke kapke added the high priority This PRs should be reviewed and merged ASAP label Oct 29, 2020
@kapke kapke self-assigned this Oct 29, 2020
mmrozek
mmrozek approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirkoAlic mirkoAlic merged commit a203f0f into develop Oct 29, 2020
@mirkoAlic mirkoAlic deleted the async-config-fix branch October 29, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mmrozek mmrozek mmrozek approved these changes

@KonradStaniec KonradStaniec KonradStaniec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kapke kapke

Labels

high priority This PRs should be reviewed and merged ASAP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kapke @mmrozek @KonradStaniec @mirkoAlic