[Fix] Non checkpoint blocks after ECIP1097 should have HefPostEcip1097 extra fields #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntallar
force-pushed
the
fix/non-checkpoint-blocks-invalid
branch
from
b9be290 to
3bafa64
Compare
ntallar
changed the title
pslaski
approved these changes
Oct 28, 2020
pslaski
suggested changes
Oct 28, 2020
Contributor
pslaski
left a comment
pslaski
left a comment
There was a problem hiding this comment.
I tried the scenario when isECIP1097 is activated, but not isECIP1098 and mocked mined block is not passing a validation. The problem is validateExtraFields method which assumes that isECIP1097 is always activated with isECIP1098
Author
|
For now ECIP1098 has to always be activated before ECIP1097 and we are assuming for now that that will be the behaviour on any testnet used, as was described here: #709 I'll add a comment on the ECIPs configuration on that assumption |
pslaski
approved these changes
Oct 29, 2020
…CIP 1098 activation block numbers
rtkaczyk
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes how extra fields from blocks are generated after ECIP1097 activation.
Proposed Solution
We were currently not considering ECIP1097 (checkpoiting) when generating blocks, so they were still generated with HefECIP1098 (treasury), and no checkpoint field then. This made all post ECIP1097 blocks generated to marked as invalid.
Scenario that failed
Configure Mantis with:
Start and mine more than 10 blocks, on develop, the block 10 generated would fail
Testing