[ETCM-79] checkpointing QA JRC #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pslaski
approved these changes
Oct 15, 2020
| val keys = privateKeys.map { key => | ||
| crypto.keyPairFromPrvKey(key.toArray) | ||
| } | ||
| val signatures = keys.map(ECDSASignature.sign(blockHash.toArray, _, None)) |
Contributor
There was a problem hiding this comment.
Could you add TODO about #738 to remember to add sorting here too?
ntallar
requested changes
Oct 16, 2020
src/main/scala/io/iohk/ethereum/jsonrpc/QAJsonMethodsImplicits.scala
Outdated
Show resolved
Hide resolved
Contributor
|
After margin [ETCM-141] scalafmt . This PR can be updated by git merge |
rtkaczyk
force-pushed
the
etcm-79-checkpointing-qa
branch
2 times, most recently
from
1e2a14d to
3ab9b0d
Compare
ntallar
approved these changes
Oct 20, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
3ab9b0d to
49b8a81
Compare
rtkaczyk
force-pushed
the
etcm-79-checkpointing-qa
branch
from
49b8a81 to
e3839b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkpointing helpers for QA
Proposed Solution
Add to new JRC methods:
qa_generateCheckpointTesting
Unit tests + manual testing with Insomnia performed