[ETCM-177] Fix Ommers pool #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix ommers calculation at pool level - Query by parentBlockHash instead of blockNumber - Remove Block inclusion as ommer for mined blocks that are not been imported (Testnet issue) - Increase OmmersPool test coverage
mirkoAlic
force-pushed
the
ETCM-177-Improve-ommers-pool-handling
branch
from
7abfcc2 to
4fe8dfd
Compare
mirkoAlic
commented
Oct 6, 2020
| if (!state.importing) { | ||
| importMinedBlock(block, state) | ||
| } else { | ||
| ommersPool ! AddOmmers(block.header) |
Contributor
Author
There was a problem hiding this comment.
this plus how ommers pool previously behave, it was the Testnet issue.
mirkoAlic
force-pushed
the
ETCM-177-Improve-ommers-pool-handling
branch
from
886bbe4 to
f15127e
Compare
mmrozek
reviewed
Oct 7, 2020
Contributor
Author
|
I merged given is needed for experimental testnet purposes. cc @jmendiola222 , @mmrozek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ommers calculation at pool level and remove addition of mined blocks that are not imported.
Up to discussion
As a future improvement it would be nice to make the Ommers pool a more "independent" component that handle the removal of ommers by its own.
Important Changes Introduced
Testing
Unit tests should passed + we monitoring this at testnet level.