[ETCM-78 added checkpointing JRC #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pslaski
force-pushed
the
etcm-78-checkpointing-jrc
branch
2 times, most recently
from
b107edd to
b89ba0e
Compare
ntallar
requested changes
Oct 7, 2020
src/main/scala/io/iohk/ethereum/jsonrpc/JsonRpcController.scala
Outdated
Show resolved
Hide resolved
src/test/scala/io/iohk/ethereum/jsonrpc/CheckpointingJRCSpec.scala
Outdated
Show resolved
Hide resolved
pslaski
force-pushed
the
etcm-78-checkpointing-jrc
branch
2 times, most recently
from
66a7921 to
fe61eb4
Compare
ntallar
requested changes
Oct 9, 2020
| response should haveResult(expectedResult) | ||
| } | ||
|
|
||
| it should "getLatestBlock in case of blockchain re-org" in new TestSetup { |
There was a problem hiding this comment.
Isn't this more a test for the CheckpointingServiceSpec?
rtkaczyk
reviewed
Oct 12, 2020
pslaski
force-pushed
the
etcm-78-checkpointing-jrc
branch
from
fe61eb4 to
6f36736
Compare
rtkaczyk
approved these changes
Oct 13, 2020
pslaski
force-pushed
the
etcm-78-checkpointing-jrc
branch
from
6f36736 to
63dacbf
Compare
pslaski
force-pushed
the
etcm-78-checkpointing-jrc
branch
from
63dacbf to
e6f4714
Compare
ntallar
approved these changes
Oct 13, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ported Checkpointing JRC
Important Changes Introduced
Testing
use insomnia endpoints