[Chore] Fix compilation issues with updated web3j #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemastero
approved these changes
Sep 30, 2020
mmrozek
reviewed
Sep 30, 2020
Contributor
mmrozek
left a comment
mmrozek
left a comment
There was a problem hiding this comment.
The changes from .circleci/config should be reflected in buildkite config
Contributor
if you are referring to compile-all step, that is already there: https://github.com/input-output-hk/mantis/pull/707/files#diff-4bc7af90a8380d7ed64283e70a4d7f2dR15 |
mirkoAlic
changed the title
mirkoAlic
suggested changes
Sep 30, 2020
lemastero
reviewed
Oct 1, 2020
.circleci/config.yml
Outdated
| name: additional compilation & dist | ||
| # this step builds parts of the codebase which are not tested in CI | ||
| # so as to prevent compilation regression | ||
| command: $SBT benchmark:compile snappy:compile dist |
Contributor
There was a problem hiding this comment.
Maybe we could keep dist step?
Contributor
There was a problem hiding this comment.
Is already included for buildkite pipeline: https://github.com/input-output-hk/mantis/pull/707/files#diff-4bc7af90a8380d7ed64283e70a4d7f2dR84
or you mean having it as a separate step?
…nto chore-update-web3j Conflicts: - .circleci/config.yml + "org.web3j" % "core" % "5.0.0" TODO: Apply nix-expr.patch from buildkite run!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compilation issues with updated web3j,
make Circle compile all targets.