Skip to content

Conversation

@sevanspowell
Copy link
Contributor

Description

  • Use Nixkite to define a Buildkite pipeline in Nix.
  • Modify the "test-ets.sh" script to reflect the new Buildkite
    environment.
  • Remove old CircleCI config.
  • Update the solidity compiler to version 0.5.1 because that's the
    version currently available in the Nix environment.

@sevanspowell sevanspowell force-pushed the feature/ETCM-100-buildkite-integration branch from 0e86807 to f92a7d8 Compare September 29, 2020 07:35
@sevanspowell
Copy link
Contributor Author

Note that the CircleCI build check will fail because I've removed all the CircleCI config. I'll disable that check when everyone is happy with this PR.

@@ -0,0 +1,68 @@
# steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments can be remove now? or the idea is to keep them for some reason? (minor)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mirkoAlic, they should be removed, I'll do that now :)


- run:
name: FULL ETS
command: RUN_FULL_ETS=yes ./test-ets.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the scope of this task, but we should think how we could add this into our CI flow. Current main issue is that it take to much time.

Copy link
Contributor

@mirkoAlic mirkoAlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sevanspowell sevanspowell force-pushed the feature/ETCM-100-buildkite-integration branch from fc27c9c to 7f94164 Compare September 30, 2020 07:25
- Use Nixkite to define a Buildkite pipeline in Nix.
- Modify the "test-ets.sh" script to reflect the new Buildkite
  environment.
- Remove old CircleCI config.
- Update the solidity compiler to version 0.5.1 because that's the
  version currently available in the Nix environment.
@sevanspowell sevanspowell force-pushed the feature/ETCM-100-buildkite-integration branch from 7f94164 to 2a41345 Compare September 30, 2020 07:26
@sevanspowell sevanspowell merged commit d1fdd7a into develop Sep 30, 2020
@mirkoAlic mirkoAlic deleted the feature/ETCM-100-buildkite-integration branch September 30, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants