-
Notifications
You must be signed in to change notification settings - Fork 78
Migrate CircleCI to Buildkite #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e86807 to
f92a7d8
Compare
|
Note that the CircleCI build check will fail because I've removed all the CircleCI config. I'll disable that check when everyone is happy with this PR. |
.buildkite/pipeline.yml
Outdated
| @@ -0,0 +1,68 @@ | |||
| # steps: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments can be remove now? or the idea is to keep them for some reason? (minor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @mirkoAlic, they should be removed, I'll do that now :)
|
|
||
| - run: | ||
| name: FULL ETS | ||
| command: RUN_FULL_ETS=yes ./test-ets.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the scope of this task, but we should think how we could add this into our CI flow. Current main issue is that it take to much time.
mirkoAlic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fc27c9c to
7f94164
Compare
- Use Nixkite to define a Buildkite pipeline in Nix. - Modify the "test-ets.sh" script to reflect the new Buildkite environment. - Remove old CircleCI config. - Update the solidity compiler to version 0.5.1 because that's the version currently available in the Nix environment.
7f94164 to
2a41345
Compare
Description
environment.
version currently available in the Nix environment.